Skip to content

[RSDK-8344] Expose machine internet connectivity #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

[RSDK-8344] Expose machine internet connectivity #474

merged 2 commits into from
Sep 5, 2025

Conversation

danielbotros
Copy link
Member

@danielbotros danielbotros commented Sep 5, 2025 •
edited
Loading

Description

  • Extend ClientConn interface to expose GetState so that we can call it on connections that have an underlying type of grpc.ClientConn in the rdk
  • Not worrying about webrtc connections for now, just return default Unknown state
  • Testing and other info found in corresponding RDK PR

danielbotros
danielbotros commented Sep 5, 2025
View reviewed changes
rpc/wrtc_client_channel.go
Comment on lines +338 to +339
func (ch *webrtcClientChannel) GetState() connectivity.State {
return Unknown
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a TODO here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, can you make a ticket and add a TODO here?

@viambot viambot added the safe to test Mark as safe to test label Sep 5, 2025
@danielbotros danielbotros changed the title Extend ClientConn inteface to include GetState and handle webrtc case [RSDK-8344] Expose machine internet connectivity Sep 5, 2025
@danielbotros danielbotros mentioned this pull request Sep 5, 2025
Merged
@danielbotros danielbotros requested a review from cheukt September 5, 2025 16:04
@danielbotros danielbotros marked this pull request as ready for review September 5, 2025 16:04
cheukt
cheukt approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with adding the ticket and TODO

rpc/wrtc_client_channel.go
Comment on lines +338 to +339
func (ch *webrtcClientChannel) GetState() connectivity.State {
return Unknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, can you make a ticket and add a TODO here?

@danielbotros danielbotros merged commit 3911cad into viamrobotics:main Sep 5, 2025
4 checks passed
@viambot viambot added safe to test Mark as safe to test and removed safe to test Mark as safe to test labels Sep 5, 2025
cheukt added a commit to cheukt/goutils that referenced this pull request Sep 19, 2025
@cheukt
Revert "[RSDK-8344] Expose machine internet connectivity (viamrobotic…
b9d3377 
…s#474)"

This reverts commit 3911cad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

Assignees
No one assigned
Labels
safe to test Mark as safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbotros @cheukt @viambot