-
Notifications
You must be signed in to change notification settings - Fork 416
set of windows (mingw64) build fixes #3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set of windows (mingw64) build fixes #3090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @w0lek. regarding the getline function, even if it wasn't unused I fully support removing it. Seems like a relic from the old C days.
Other than that I had a suggestion on a way to avoid ifdefs for windows compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest just using std::math::pi instead of bringing in the _USE_MATH_DEFINES
…r ezgl/graphics.hpp subtree
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are a couple compilation fixes for mingw64 build
Description
Two kind of changes:
This function has compilation issue and is not actually used and looks obsolete.
If removing is not an option, i will think how to correct code without removing it.
Related Issue
#3076
Motivation and Context
Allows to build application on windows platform using mingw64
How Has This Been Tested?
It was tested as a part of hotfixes for a several releases in Aurora package (windows build)
Types of changes
Checklist: