Skip to content

Conversation

@pranaygp
Copy link
Collaborator

@pranaygp pranaygp commented Nov 13, 2025

Just adding a new e2e test for the fix in #322.

Didn't add it to that PR directly because this e2e test will likely fail in different places for different reasons and it shouldn't block #322 for an immediate fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

⚠️ No Changeset found

Latest commit: b9218f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 13, 2025 4:07am
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 13, 2025 4:07am
example-workflow Ready Ready Preview Comment Nov 13, 2025 4:07am
workbench-hono-workflow Ready Ready Preview Comment Nov 13, 2025 4:07am
workbench-nitro-workflow Ready Ready Preview Comment Nov 13, 2025 4:07am
workbench-nuxt-workflow Ready Ready Preview Comment Nov 13, 2025 4:07am
workbench-sveltekit-workflow Ready Ready Preview Comment Nov 13, 2025 4:07am
workbench-vite-workflow Ready Ready Preview Comment Nov 13, 2025 4:07am
workflow-docs Ready Ready Preview Comment Nov 13, 2025 4:07am

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pranaygp pranaygp force-pushed the pranaygp/11-12-add_fatal_step_e2e_test branch from 41ce56b to a88c40b Compare November 13, 2025 04:02
@pranaygp pranaygp force-pushed the pranaygp/11-12-fix_workflow_failing_because_of_function_timeouts branch from 7460e25 to c1333ed Compare November 13, 2025 04:02
Copy link
Member

@VaguelySerious VaguelySerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works in prod but the output shape is just slightly off?
image


And then it fails in local generally presumably because killing the process will kill more than just the API handler, since it's all running the same process?

Base automatically changed from pranaygp/11-12-fix_workflow_failing_because_of_function_timeouts to main November 19, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants