get_block_coinbase (rename to view_coinbase)? #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. get_block_coinbase(inp) returns block's coinbase text inp=0, "EThe Times 03/Jan/2009 Chancellor on brink of second bailout for banks"; inp=142573, "'Eligius7Militant atheists, http://bit.ly/naNhG2 -- happy now?'") 2. lambda st, by functions added (for cross-version encoding) 3. make_request returns bytes in Python 3, encoded as string \, lest json.loads fail
|
Has anyone got a better way to check the coinbase field and filter out non-printable characters? ie, note the 'E' in front of the block 0 coinbase text returned, or the random chars here @ 142573 |
|
I like it for py3 support, a much better way to convert to str, better than having to touch all the json.loads(). this seems like a good fragment for filtering non-printable? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inp=0, "EThe Times 03/Jan/2009 Chancellor on brink of second bailout for banks";
inp=142573, "'Eligius7Militant atheists, http://bit.ly/naNhG2 -- happy now?'")