Skip to content

Fix Failing Tests, Address Client Connection Issue #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jhoughjr
Copy link
Collaborator

Updated from swift-tools-version:5.7 to 5.9.
This fixes an issue where clients would get a bad Sec-WebSocket-Accept value from vapor.

Fixed bad url tests on WebSocket, Async and regular.

There is an issue for covering all bad urls that the WebSocket might reject as URL seems to init fragments such as bare escape sequences. I'm not sure yet how that could be covered better, or how important it is.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (a935b63) to head (2859454).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files           6        6           
  Lines         659      659           
=======================================
  Hits          546      546           
  Misses        113      113           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gwynne
Copy link
Member

gwynne commented Nov 22, 2024

The semantics of URL's validation changed noticeably in Swift 6.0, hence the CI failure.

@0xTim
Copy link
Member

0xTim commented Nov 22, 2024

We really shouldn't be touching BoringSSL anymore

@gwynne
Copy link
Member

gwynne commented Nov 22, 2024

We really shouldn't be touching BoringSSL anymore

Yeah, but that's out of scope for this PR.

@jhoughjr
Copy link
Collaborator Author

Ill check these tests and update.

@jhoughjr
Copy link
Collaborator Author

Im beginning to think there is no way to resolve this issue with this test. The behavior is not consistent enough across swift versions and platforms. The utility of the test is unknown to me also.

I don't know how to even do it (much less elegantly), to handle URL initialization across versions and platforms.
I'd also argue this is kinda testing URL and we don't own that. idk im not of much use.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise this was building! @gwynne any comments on this?

@0xTim 0xTim added the semver-minor Contains new APIs label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants