Skip to content

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Jun 17, 2025

Closes #132

This adds a new ContentDisposition type to be able to type-safely parse Content-Disposition header fields.

Also adds some docs

@ptoffy ptoffy requested review from 0xTim and gwynne as code owners June 17, 2025 13:13
/// - Parameter field: The raw Content-Disposition header field value.
/// - Throws: `ContentDisposition.Error` if the header has an invalid format, contains an
/// unrecognized disposition type, or is missing required fields.
init(from field: HTTPFields.Value) throws(ContentDisposition.Error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be public

Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one issue this looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for returning all the content-disposition parameters
2 participants