Перехватываем вывод независимо от наличия ошибок #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Вывод выполнения консольного приложения возвращался независимо от того, выполнилось приложение с ошибками или нет. Closes vanessa-opensource#799
artbear
requested changes
Oct 28, 2020
There was a problem hiding this comment.
@kuntashov ты добьешь ПР #800 с кавычками?
6 или 7 кавычек подряд )
Исправил в 5586e99 |
artbear
reviewed
Feb 21, 2021
There was a problem hiding this comment.
к сожалению, в режиме асинхронности нельзя юзать синхронные методы Файл.Существует и ЭтоФайл (
Поэтому я делал обходной маневр и не проверяю наличие файла, по возможности.
предлагаю и здесь отказаться от этих методов и сразу читать файл
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Вывод выполнения консольного приложения возвращается независимо от того, выполнилось приложение с ошибками или нет.
Closes #799
@vanessa-opensource/Collaborators - просьба прокомментировать и проверить