fix for deployment app-tendermint logging issue with the same file op…

[solarw]

…ened

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

• Non-breaking fix (non-breaking change which fixes an issue)
• Breaking fix (breaking change which fixes an issue)
• Non-breaking feature (non-breaking change which adds functionality)
• Breaking feature (breaking change which adds functionality)
• Refactor (non-breaking change which changes implementation)
• Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• I am making a pull request against the main branch (left side). Also you should start your branch off our main.
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have locally run services that could be impacted and they do not present failures derived from my changes
• Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
• Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[codecov]

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.92%. Comparing base (0453db5) to head (745f49f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/valory/connections/abci/connection.py	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2357      +/-   ##
==========================================
+ Coverage   84.89%   84.92%   +0.02%     
==========================================
  Files         225      225              
  Lines       16496    16501       +5     
==========================================
+ Hits        14005    14013       +8     
+ Misses       2491     2488       -3     

Flag	Coverage Δ
unittests	84.92% <71.42%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[OjusWiZard]

Also, I tried running with these changes and something is off...
Now the logs are some lines and then full of empty strings, could you check what's wrong here?

Attaching the logs here.

node_0.txt

[OjusWiZard]

I'd suggest to keep them identical even if it's not needed in the connections code, and let this test as it was.
My reasoning is that, its fine to comment it right now, but removing this test mean that in may slip other changes also in the future, which would need to be identical. So, letting the process unchanged will avoid problems in the future.

[OjusWiZard]

Also, I just realise! Why not do the same fix in the connections also? It would also be creating this bug too right?

[OjusWiZard]

we already have this in deployments/Dockerfiles/tendermint/tendermint.py