Skip to content

Conversation

@ritsukai
Copy link

  • Add Base chain support to MECH_FACTORY_ADDRESS in operate/services/utils/mech.py
  • Add Base marketplace to DEFAULT_PRIORITY_MECH in operate/ledger/profiles.py

This enables olas-operate-middleware to work with mech marketplaces on Base chain.

Proposed changes

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

- Add Base chain support to MECH_FACTORY_ADDRESS in operate/services/utils/mech.py
- Add Base marketplace to DEFAULT_PRIORITY_MECH in operate/ledger/profiles.py

This enables olas-operate-middleware to work with mech marketplaces on Base chain.
Comment on lines +143 to +146
"0xf24eE42edA0fc9b33B7D41B06Ee8ccD2Ef7C5020": (
"0x77af31De935740567Cf4fF1986D04B2c964A786a",
0,
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service Id is 0, is it because it's unknown?

Copy link

@kupermind kupermind Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The address seems not correct, it's not even a contract. In fact, it's the legacy mech on Gnosis :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: still no production default priority mech ATM. Please let's hold back on these additions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole block needs to be removed or commented out for now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritsukai could you please remove this block for now as it is not correct at this point of time?

Comment on lines +47 to +53
},
Chain.BASE: {
"0xf24eE42edA0fc9b33B7D41B06Ee8ccD2Ef7C5020": {
"Native": "0x2E008211f34b25A7d7c102403c6C2C3B665a1abe",
"Token": "0x97371B1C0cDA1D04dFc43DFb50a04645b7Bc9BEe",
"Nevermined": "0x847bBE8b474e0820215f818858e23F5f5591855A",
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are correct

Copy link

@ritsuKai2000 ritsuKai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sourcing the contracts! I should have been clearer that it was a placeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants