-
Couldn't load subscription status.
- Fork 4
feat: add Base chain mech marketplace support #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add Base chain support to MECH_FACTORY_ADDRESS in operate/services/utils/mech.py - Add Base marketplace to DEFAULT_PRIORITY_MECH in operate/ledger/profiles.py This enables olas-operate-middleware to work with mech marketplaces on Base chain.
| "0xf24eE42edA0fc9b33B7D41B06Ee8ccD2Ef7C5020": ( | ||
| "0x77af31De935740567Cf4fF1986D04B2c964A786a", | ||
| 0, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The service Id is 0, is it because it's unknown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The address seems not correct, it's not even a contract. In fact, it's the legacy mech on Gnosis :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed: still no production default priority mech ATM. Please let's hold back on these additions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole block needs to be removed or commented out for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritsukai could you please remove this block for now as it is not correct at this point of time?
| }, | ||
| Chain.BASE: { | ||
| "0xf24eE42edA0fc9b33B7D41B06Ee8ccD2Ef7C5020": { | ||
| "Native": "0x2E008211f34b25A7d7c102403c6C2C3B665a1abe", | ||
| "Token": "0x97371B1C0cDA1D04dFc43DFb50a04645b7Bc9BEe", | ||
| "Nevermined": "0x847bBE8b474e0820215f818858e23F5f5591855A", | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sourcing the contracts! I should have been clearer that it was a placeholder
This enables olas-operate-middleware to work with mech marketplaces on Base chain.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply