Skip to content

Conversation

bakoushin
Copy link
Contributor

Description

Migrate @react-native-cookies/cookies to @divvi/cookies

The patch changes are implemented in the fork:
react-native-cookies/cookies@master...divvixyz:cookies:master

Although we are not using it directly, it is a peer dependency for fiatconnect-sdk (this package is already updated).

TODO

Migrate back to the original package once react-native-cookies/cookies#189 is merged.

Test plan

  • CI
  • Next release App Store submission (patch is adding the PrivacyInfo.xcprivacy file)

Related issues

Backwards compatibility

Y

Network scalability

NA

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (736c0ec) to head (06f6511).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6482      +/-   ##
==========================================
- Coverage   89.07%   89.06%   -0.01%     
==========================================
  Files         729      729              
  Lines       31848    31848              
  Branches     6138     5816     -322     
==========================================
- Hits        28368    28367       -1     
- Misses       3282     3433     +151     
+ Partials      198       48     -150     

see 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736c0ec...06f6511. Read the comment docs.

@bakoushin bakoushin added this pull request to the merge queue Feb 6, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2025
…es` (#6482)

### Description

Migrate `@react-native-cookies/cookies` to `@divvi/cookies`

The patch changes are implemented in the fork:

react-native-cookies/cookies@master...divvixyz:cookies:master

Although we are not using it directly, it is a [peer
dependency](https://github.com/fiatconnect/fiatconnect-sdk/blob/065ba70bd5dde23fa186d161072eb024e0cde40d/package.json#L56)
for `fiatconnect-sdk` (this package is already
[updated](fiatconnect/fiatconnect-sdk#330)).

### TODO

Migrate back to the original package once
react-native-cookies/cookies#189 is merged.

### Test plan

* CI
* Next release App Store submission (patch is adding the
`PrivacyInfo.xcprivacy` file)

### Related issues

- Related to RET-1308

### Backwards compatibility

Y

### Network scalability

NA
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@bakoushin bakoushin added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit ec54f08 Feb 6, 2025
16 checks passed
@bakoushin bakoushin deleted the alex/react-native-cookies branch February 6, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants