Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 6, 2025

-        "Programming Language :: Python :: Free Threading",

This undoes a mistake made at:

because there are thread-unsafe tests as demonstrated in:

Copilot AI review requested due to automatic review settings November 6, 2025 13:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the "Programming Language :: Python :: Free Threading" classifier from the project's setup configuration. This appears to be a cleanup change to remove a potentially invalid or unsupported PyPI trove classifier.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mkmkme
Copy link
Collaborator

mkmkme commented Nov 8, 2025

Yeah, thanks. I was thinking about removing it myself.
Could you remove it from the CI as well for now? I can see the testing with free-threading Python requires some hacks at this moment that effectively remove the benefits of free threading completely. Proper support for free threading requires more effort, so we will address it later.

Copilot AI review requested due to automatic review settings November 8, 2025 18:43
@cclauss cclauss changed the title Remove free-threaded trove classifier Remove free-threaded tests and trove classifier Nov 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mkmkme mkmkme merged commit 5043f36 into valkey-io:main Nov 12, 2025
39 of 40 checks passed
@cclauss cclauss deleted the remove-free-threaded-trove-classifier branch November 13, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants