Skip to content

Conversation

Nekrolm
Copy link
Contributor

@Nekrolm Nekrolm commented Sep 24, 2025

Rewrite DFS method in iterative way to avoid stack overflows

Closes #8695

PR is on top of #8694
but changes are independent. Only top commit can be cherry-picked, if needed

@sylvestre
Copy link
Contributor

please add a test that trigger the stackoverflow

Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Performance Report

Merging #8737 will not alter performance

Comparing Nekrolm:tsort-no-recursion (129d362) with main (5c15d79)

Summary

✅ 41 untouched
⏩ 64 skipped1

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@Nekrolm Nekrolm force-pushed the tsort-no-recursion branch 2 times, most recently from 86c8710 to f5dfb27 Compare September 25, 2025 10:03
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@Nekrolm Nekrolm force-pushed the tsort-no-recursion branch 4 times, most recently from 90ac3c2 to 8f0bf8b Compare September 25, 2025 11:43
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsort: segfault on large cycles
2 participants