-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Allow to use any profile from make install #8730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Allow to use any profile e.g. `make install PROFILE=release-fast`
Could you please add a check in the ci to make sure we don't regress in the future, thanks |
No idea about what should I test. Everything are installed at same place for each PROFILE... |
GNU testsuite comparison:
|
CodSpeed Performance ReportMerging #8730 will not alter performanceComparing Summary
Footnotes
|
something like this: |
Add test for `make install PROFILE=release-fast`
Included |
GNU testsuite comparison:
|
it regressed a freebsd test:
|
profile ci is defined at https://github.com/uutils/coreutils/blob/main/.config/nextest.toml . But not loaded from test for FreeBSD? |
GNU testsuite comparison:
|
freebsd.yaml has I can't determine that should I add nextest or remove |
Allow to use any profile at
make
e.g.make install PROFILE=release-fast
.