Skip to content

Conversation

oech3
Copy link
Contributor

@oech3 oech3 commented Sep 24, 2025

Allow to use any profile at make e.g. make install PROFILE=release-fast.

Allow to use any profile e.g. `make install PROFILE=release-fast`
@sylvestre
Copy link
Contributor

Could you please add a check in the ci to make sure we don't regress in the future, thanks

@oech3
Copy link
Contributor Author

oech3 commented Sep 24, 2025

No idea about what should I test. Everything are installed at same place for each PROFILE...

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/overlay-headers is no longer failing!

Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Performance Report

Merging #8730 will not alter performance

Comparing oech3:profile (fec433f) with main (32eef06)

Summary

✅ 93 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@sylvestre
Copy link
Contributor

something like this:
https://github.com/uutils/coreutils/blob/main/.github/workflows/CICD.yml#L474-L479
and verify that a few files exist

Add test for `make install PROFILE=release-fast`
@oech3
Copy link
Contributor Author

oech3 commented Sep 24, 2025

Included PROFILE=release-fast to one of a test and added test -f check.

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

it regressed a freebsd test:

 cargo build --features feat_external_libstdbuf --features "arch base32 base64 basename basenc cat chgrp chmod chown chroot cksum comm cp csplit cut date dd df dir dircolors dirname du echo env expand expr factor false fmt fold groups hashsum head hostid hostname id install join kill link ln logname ls mkdir mkfifo mknod mktemp more mv nice nl nohup nproc numfmt od paste pathchk pinky pr printenv printf ptx pwd readlink realpath rm rmdir seq shred shuf sleep sort split stat stdbuf stty sum sync tac tail tee test timeout touch tr true truncate tsort tty uname unexpand uniq unlink uptime users vdir wc who whoami yes " --profile=ci --no-default-features
  error: profile `ci` is not defined
  gmake[1]: Leaving directory '/home/runner/work/coreutils/coreutils'
  gmake[1]: *** [GNUmakefile:341: build-coreutils] Error 101

@oech3
Copy link
Contributor Author

oech3 commented Sep 24, 2025

profile ci is defined at https://github.com/uutils/coreutils/blob/main/.config/nextest.toml . But not loaded from test for FreeBSD?

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Contributor Author

oech3 commented Sep 28, 2025

freebsd.yaml has make PROFILE=ci without nextest.

I can't determine that should I add nextest or remove PROFILE=ci. Would someone edit this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants