refactor(source): dynamic marker icons #219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antontranelis
changed the title
ulfgebhardt
approved these changes
May 16, 2025
There was a problem hiding this comment.
It works - the icons are loaded form the server as expected
I corrected the type definition to avoid warnings in rollup (would likely cause not to be able to resolve the MarkerIcon type).
Further more renamed the type to Capital letter MarkerIcon as this is standard for types.
|
The correct resolution of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marker icons can dynamically passed to layer and items
needs utopia-os/utopia-map#39