Skip to content

Event order fix #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Event order fix #576

wants to merge 2 commits into from

Conversation

ZNick1982
Copy link
Contributor

This PR fixes the order of the events.
The onUploadComplete event appears prior to onChange in case of enabling a Crop or other effects.

How to reproduce:

  1. Set up the widget with crop
  2. Subscribe to events
  3. Upload file and apply the crop
  4. Event onUploadComplete will be called first. The onChange will be after.

@jeetiss
Copy link
Contributor

jeetiss commented Oct 1, 2019 •
edited
Loading

@ZNick1982, woow, first PR with vanilla js 👍🏻
Thanks, I will test and merge it later this week

@jeetiss
Copy link
Contributor

jeetiss commented Oct 9, 2019

Hello @ZNick1982, I was able to reproduce problem with events order.

But seems you fix helps only for first upload, on second event onUploadComplete will be called first again

Need some time to going deeper with this problem 🙌🏻

Снимок экрана 2019-10-09 в 21 29 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZNick1982 @jeetiss