Support allowing specific phone types #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruimarinho
requested changes
Oct 7, 2016
| if (!isArray(allowedTypes) || intersection(allowedTypes, keys(PhoneNumberType)).length !== allowedTypes.length) { | ||
| throw new Error('Phone types specified are not valid.'); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Why .map but not Array.isArray?
| } | ||
| }); | ||
|
|
||
| it('should accept a valid phone in the e164 format', () => { |
Member
There was a problem hiding this comment.
Missing test where a number belonging to an allowed type is accepted.
| * The allowed phone number types. | ||
| */ | ||
|
|
||
| if (allowedTypes) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify the phones types allowed in the
Phoneassert.With this we can, for example, only allow land line and mobile phones (avoid premium numbers).