Skip to content

feat: Aggregate most confident results to return a summary... (#37) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Aggregate most confident results to return a summary... (#37) #38

wants to merge 1 commit into from

Conversation

Sidnioulz
Copy link
Collaborator

Closes #37

@untemps untemps self-requested a review May 5, 2021 17:37
@untemps
Copy link
Owner

untemps commented May 19, 2021

Thanks for your PR.
Even if it is theorically useful to check if we return the most confident result from the list, the component is for now on restricted to handle just one transcript via the maxAlternatives property.
I may evaluate if I lift this restriction in the next few days.

@Sidnioulz
Copy link
Collaborator Author

Hi @untemps! This PR has been open for a while, feel free to close it if no longer relevant :)

Enjoy your holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untemps untemps Awaiting requested review from untemps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The returned result isn't the most confident one, and isn't complete if interimResults / continuous are used
2 participants
@Sidnioulz @untemps