rfc: Organize the python project and fix mypy lints #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
ab/organize-py-code
branch
from
0c5aa9c to
e907691
Compare
aborgna-q
force-pushed
the
ab/organize-py-code
branch
from
e907691 to
06496b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR organizes the single-file python bindings into submodules, and adds types and some
Protocols so we can re-enable the mypy checks.I tried to stay close to the original code in #3, but some changes were required (sorry if I went overboard with it).
I haven't re-exported everything from the root, we can do that if needed for backwards compatibility.
Some structs have been renamed to avoid everything being called
JeffSomething.This code is still based on the
pycapnplibrary, which is a bit deficient on wheels availability. It also requires us# type: ignoreing every import from the schema.I'll follow up with another PR trying out alternatives for that.