Create distribution packages for ubuntu (.deb release v0.0.1) #129
Conversation
|
|
||
| set(CPACK_PACKAGE_NAME "unicode-inflection") | ||
| set(CPACK_PACKAGE_VENDOR "Unicode Consortium") | ||
| set(CPACK_PACKAGE_CONTACT "[email protected]") |
There was a problem hiding this comment.
I think we need to find another contact. I'm not sure that I'm ready to have my email address here.
There was a problem hiding this comment.
Is that a mandatory field? If we have to have it, we can use the [email protected] one.
There was a problem hiding this comment.
I’d prefer just listing the official GitHub project. The discussion page can be used for communication.
|
|
||
| # DEB-specific options | ||
| set(CPACK_DEBIAN_PACKAGE_MAINTAINER "Unicode Consortium <[email protected]>") | ||
| set(CPACK_DEBIAN_PACKAGE_DEPENDS "libicu-dev (>= 77.1)") |
There was a problem hiding this comment.
The dev part is only needed for building. The non-dev dependency is needed for runtime.
| - 'v*' | ||
| workflow_dispatch: | ||
| pull_request: | ||
| branches: [ main, master ] |
There was a problem hiding this comment.
I don't think we need the master part. It's obsolete and our repo doesn't have it.
| with: | ||
| lfs: true | ||
|
|
||
| - name: Setup Git LFS |
There was a problem hiding this comment.
We can land it as is for now, but fix it after Frank lands 128 (LFS caching).
| sudo apt update | ||
| sudo apt install -y cmake build-essential clang pkg-config | ||
|
|
||
| - name: Install ICU 77.1 |
There was a problem hiding this comment.
ICU caching already landed - we can use it here to save bandwidth.
|
|
||
| set(CPACK_PACKAGE_NAME "unicode-inflection") | ||
| set(CPACK_PACKAGE_VENDOR "Unicode Consortium") | ||
| set(CPACK_PACKAGE_CONTACT "[email protected]") |
There was a problem hiding this comment.
Is that a mandatory field? If we have to have it, we can use the [email protected] one.
| - name: Install ICU 77.1 | ||
| run: | | ||
| cd /tmp | ||
| wget https://github.com/unicode-org/icu/releases/download/release-77-1/icu4c-77_1-src.tgz |
There was a problem hiding this comment.
Why do we download and compile sources? Why not just download and install binary release for Ubuntu? It takes time to compile ICU.
One needs to only copy the $download_location/usr tree to /usr/local/ folder
There was a problem hiding this comment.
See https://github.com/unicode-org/inflection/pull/128/files for example on how to do it.
This PR introduces a workflow for building and packaging the Unicode Inflection library on Ubuntu using CPack. It generates .deb and .tar.gz artifacts and uploads them via GitHub Actions on tag push. ICU 77.1 is built from source as a prerequisite.
Key Changes
Added CPack configuration in CMakeLists.txt to generate:
Added GitHub Actions workflow:
Workflow File:
.github/workflows/create-ubuntu-distribution-package.yml
Release Target:
Ubuntu .deb package only for now