CLDR-18697 Use static PathStarrer.computeIfAbsent where possible #4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Assume that it is safe to use STAR_PATTERN instead of simple * -Change starrer.set to static PathStarrer.computeIfAbsent if pattern is * or unchanged from default STAR_PATTERN, unless getAttributes is called on an instance -Remove implements Transform and the transform method, apparently unused for PathStarrer -Remove unused method getSubstitutionPattern -Rename the 2-argument set method to setSkippingAttributes, to disambiguate at least for now; the 2-argument method has only a single caller, in TestAlt -In the 1-argument set method, avoid calling the 2-argument method, for simplicity and performance, at least for now
macchiati
reviewed
Jun 11, 2025
| @@ -286,7 +285,7 @@ static void showInconsistenciesInLocale(String locale) { | |||
| continue; | |||
| } | |||
| if (SHOW_PROGRESS_RAW) { | |||
| ps.set(path); | |||
| PathStarrer.computeIfAbsent(path); | |||
There was a problem hiding this comment.
This is strange, looks like the value is never used.
There was a problem hiding this comment.
Seems like that was already the case. Also, SHOW_PROGRESS_RAW is false, so maybe this is part of an incomplete unused feature.
There was a problem hiding this comment.
I've removed that line in the 2nd commit
-In ShowInconsistentAvailable, the starred path was computed but unused -Note that the code in question also depends on SHOW_PROGRESS_RAW, which is false
macchiati
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Assume that it is safe to use STAR_PATTERN instead of simple *
-Change starrer.set to static PathStarrer.computeIfAbsent if pattern is * or unchanged from default STAR_PATTERN, unless getAttributes is called on an instance
-Remove
implements Transformand the transform method, apparently unused for PathStarrer-Remove unused method getSubstitutionPattern
-Remove already-unused ExampleCache.pathStarrer; revise related comments
-Rename the 2-argument set method to setSkippingAttributes, to disambiguate at least for now; the 2-argument method has only a single caller, in TestAlt
-In the 1-argument set method, avoid calling the 2-argument method, for simplicity and performance, at least for now
CLDR-18697
ALLOW_MANY_COMMITS=true