CLDR-7459 make sideways view be by-request #4793
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
requested review from
btangmu,
conradarcturus,
macchiati,
AEApple and
pedberg-icu
|
Looks good on first glance; this is for later, not today, right? |
|
How does it work? When you hit the button, does it load the sublocales and then change the button to a pulldown? |
macchiati
requested changes
Jun 9, 2025
You get the button instead of the menu if you push the button on the menu appears that's it |
|
ok, sounds good. |
|
Withdrew my review; will leave it up to Tom to review the JS |
Sounds good… I moved it back to draft because we also need to revert the earlier disablement or it won't have any effect I should add also that the button disappears once clicked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-7459
also see #4792
ALLOW_MANY_COMMITS=true