Skip to content

Conversation

@pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Aug 25, 2025

AB#236494: Refactoring: Move all models except Grievance related into models package

  • conflicts
  • linter Found 339 errors.
  • test with new migrations
  • unit tests 23 failed 🚫
  • e2e tests

@pavlo-mk pavlo-mk changed the title move models WIP // Un modelo - One model Aug 25, 2025
@pavlo-mk pavlo-mk self-assigned this Aug 25, 2025
@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Aug 25, 2025
@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 91.14533% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.89%. Comparing base (7274917) to head (b863ef6).

Files with missing lines Patch % Lines
src/hope/apps/payment/celery_tasks.py 72.91% 13 Missing ⚠️
src/hope/admin/user.py 55.55% 8 Missing ⚠️
...ayment/services/verification_plan_crud_services.py 40.00% 6 Missing ⚠️
src/hope/apps/account/authentication.py 0.00% 5 Missing ⚠️
src/hope/apps/core/base_test_case.py 54.54% 5 Missing ⚠️
src/hope/apps/account/caches.py 0.00% 3 Missing ⚠️
src/hope/apps/core/celery_tasks.py 25.00% 3 Missing ⚠️
src/hope/admin/business_area.py 71.42% 2 Missing ⚠️
src/hope/admin/partner.py 77.77% 2 Missing ⚠️
src/hope/admin/xlsupdate.py 33.33% 2 Missing ⚠️
... and 37 more

❌ Your patch check has failed because the patch coverage (91.14%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5084      +/-   ##
===========================================
+ Coverage    86.84%   86.89%   +0.05%     
===========================================
  Files          700      772      +72     
  Lines        38181    39092     +911     
===========================================
+ Hits         33157    33968     +811     
- Misses        5024     5124     +100     
Flag Coverage Δ
e2e 86.89% <91.14%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Conflicts:
#	src/frontend/src/restgenerated/services/RestService.ts
#	src/hope/apps/account/filters.py
#	src/hope/apps/account/migrations/0018_migration.py
#	src/hope/apps/account/models.py
#	src/hope/apps/core/models.py
#	src/hope/apps/geo/models.py
#	src/hope/apps/household/api/views.py
#	src/hope/apps/payment/celery_tasks.py
#	src/hope/apps/payment/models/payment.py
#	src/hope/apps/payment/xlsx/xlsx_payment_plan_export_per_fsp_service.py
#	src/hope/apps/registration_data/services/template_generator_service.py
#	src/hope/models/household.py
#	src/hope/models/program.py
#	src/hope/models/registration_data_import.py
#	tests/unit/apps/grievance/test_grievance_create_data_change.py
#	tests/unit/apps/grievance/test_grievance_ticket_create.py
#	tests/unit/apps/payment/test_payment_gateway_service.py
#	tests/unit/apps/payment/test_payment_token_and_order_numbers.py
#	tests/unit/apps/utils/test_payment_plan_celery_tasks_mixin.py
# Conflicts:
#	src/hope/api/endpoints/rdi/base.py
#	src/hope/apps/core/migrations/0013_migration.py
#	src/hope/apps/core/models.py
#	src/hope/models/program.py
#	tests/unit/apps/account/test_migration_of_roles_and_permissions.py
# Conflicts:
#	src/hope/api/endpoints/rdi/lax.py
# Conflicts:
#	src/frontend/src/restgenerated/models/PaymentRecordDeliveryTypeEnum.ts
#	src/hope/apps/payment/migrations/0045_migration.py
#	src/hope/apps/payment/migrations/0046_migration.py
#	src/hope/apps/payment/models/payment.py
#	src/hope/apps/payment/services/payment_plan_services.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Change doesn't need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants