[LMSM] Fixes UAT Test Locations and Stock #4083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbonet
reviewed
Oct 16, 2025
src/etools/applications/last_mile/tests/test_admin_panel/test_manage_locations.py
Outdated
Show resolved
Hide resolved
fpbonet
reviewed
Oct 16, 2025
src/etools/applications/last_mile/tests/test_admin_panel/test_manage_locations.py
Outdated
Show resolved
Hide resolved
fpbonet
reviewed
Oct 16, 2025
fpbonet
reviewed
Oct 16, 2025
| uom=item.get('uom'), | ||
| batch_id=item.get('item_name'), | ||
| expiry_date=item.get('expiration_date'), | ||
| expiry_date=item.get('expiration_date') or item.get('expiry_date'), |
There was a problem hiding this comment.
why two different field names??
There was a problem hiding this comment.
Because we have 2 separate functions that are using this service. The expirty_date come directly from the UI and expiration_date is from BE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.