278284 agreements endpoints #4069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbonet
reviewed
Oct 2, 2025
| def get_psea_last_assessment_date(self, obj): | ||
| if getattr(obj, 'psea_assessment_date', None): | ||
| try: | ||
| return obj.psea_assessment_date.date().isoformat() |
There was a problem hiding this comment.
why would this raise an exception? and which type of exception?
There was a problem hiding this comment.
The idea here is that if psea_assessment_date is already a date (or some other type like str), calling .date() fails.
Exception type: typically AttributeError (e.g., "'datetime.date' object has no attribute 'date'")
But this might be too convoluted, let's just use a regular datefield
fpbonet
reviewed
Oct 2, 2025
| file_field = getattr(obj, 'attached_agreement', None) | ||
| if file_field: | ||
| try: | ||
| return file_field.url if file_field.name else None |
There was a problem hiding this comment.
Same here, this bit throws me off a bit... I don’t understand why you would do that there
There was a problem hiding this comment.
the idea here was that if file_field.name doesnt exist, file_field.url would throw a ValueError, but let's keep it simple with a url field.
fpbonet
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.