trying pure python cython style #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further details of pure python |
julesghub
force-pushed
the
purepy-cython
branch
from
610e3d3 to
9ef24b8
Compare
julesghub
changed the base branch from
ConstitutiveModelUpdates
to
development
|
I think we should adopt this approach. Did we stop because we need to rename the cython module in uw3 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little example of "pure python" style in cython. @lmoresi what do you think?
This will make the cython code easier to read. It can also reduce the pain between python and cython, helpful for dev/debugging.