Development #21
Open
Development #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back propagate changes from JOSS branch into the dev branch
Add JOSS doi etc (Note this will show errors until the paper is formally accepted)
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a critical bug in the KDTree algorithm and updates the README with JOSS publication information. The bug fix corrects the conditional logic for returning distance values, while the README updates add references to the Journal of Open Source Software publication.
- Fixes incorrect conditional logic in KDTree distance calculation
- Adds JOSS publication reference and DOI to README
- Updates README section heading for better organization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/underworld3/ckdtree.pyx | Fixes bug in KDTree where squared distances and regular distances were returned incorrectly |
| README.md | Adds JOSS publication information and updates references section heading |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* New Container file setup and moving Dockerfile to ContainerFile * Remove old dockerfile * add launch script * Simplification of Containerfile with new example usage * yml -> yaml: for consistency * New Containerfile and container launch script. This assumes containers will be run with `podman` and only in 'rootless podman' mode. This more is much better than 'rootful podman' or docker. * rename .yml -> .yaml * remove obsolete comment * Update build_uw3_and_test.yaml * call environment something different to 'base' * Turn off verbosity in Container image build. * Reactivate cache environment.yaml for GH workflow. * Pyvista now working in container * Fixing sym links * Adding a README.md Some useful links and overall desciption of the container technology used. * Adding a README.md Some useful links and overall desciption of the container technology used. * Update link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the README updates (these include the JOSS publication information).
The nasty bug that I introduced into the kdtree algorithm - a fix for this, I mean !
That's all.