Skip to content

Readonly of select #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Readonly of select #1017

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2107de0
Readonly of select
bjarnef Feb 16, 2025
b3419c4
Stop event if readonly and keypress unless tab key
bjarnef Feb 16, 2025
7d2f8d4
Rename function
bjarnef Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 30 additions & 11 deletions packages/uui-select/lib/uui-select.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@ declare global {
* @cssprop --uui-select-padding-x - Padding on the x axis
* @cssprop --uui-select-border-color - Border color
* @cssprop --uui-select-border-color-hover - Border color on hover
* @cssprop --uui-select-border-color-readonly - Border color when readonly
* @cssprop --uui-select-selected-option-background-color - Background color of the selected option
* @cssprop --uui-select-selected-option-color - Color of the selected option
* @cssprop --uui-select-outline-color - Outline color
* @cssprop --uui-select-background-color - Background color
* @cssprop --uui-select-disabled-background-color - Background color when disabled
* @cssprop --uui-select-background-color-disabled - Background color when disabled
* @cssprop --uui-select-background-color-readonly - Background color when readonly
* @extends UUIFormControlMixin
*/
// TODO: Consider if this should use child items instead of an array.
Expand Down Expand Up @@ -197,6 +199,14 @@ export class UUISelectElement extends UUIFormControlMixin(LitElement, '') {
);
}

private handleKeydown(e: KeyboardEvent) {
if (this.readonly && e.key !== 'Tab') {
e.preventDefault();
e.stopPropagation();
return;
}
}

private _renderOption(
name: string,
value: string,
Expand Down Expand Up @@ -237,21 +247,14 @@ export class UUISelectElement extends UUIFormControlMixin(LitElement, '') {
`;
}

private _getDisplayValue() {
return (
this.options.find(option => option.value === this.value)?.name ||
this.value
);
}

render() {
if (this.readonly) return html`<span>${this._getDisplayValue()}</span>`;

return html` <select
id="native"
aria-label=${this.label}
@change=${this.setValue}
@keydown=${this.handleKeydown}
?disabled=${this.disabled}
aria-readonly=${this.readonly ? 'true' : 'false'}
.name=${this.name}
.value=${this.value as string}>
<option disabled selected value="" hidden>${this.placeholder}</option>
Expand Down Expand Up @@ -305,9 +308,25 @@ export class UUISelectElement extends UUIFormControlMixin(LitElement, '') {
#native[disabled] {
cursor: not-allowed;
background-color: var(
--uui-select-disabled-background-color,
--uui-select-background-color-disabled,
var(--uui-color-disabled)
);
border-color: var(
--uui-select-border-color-disabled,
var(--uui-color-disabled)
);
}

#native[aria-readonly='true'] {
pointer-events: none;
background-color: var(
--uui-select-background-color-readonly,
var(--uui-color-disabled)
);
border-color: var(
--uui-select-border-color-readonly,
var(--uui-color-disabled-standalone)
);
}

#native:hover {
Expand Down
Loading