-
-
Notifications
You must be signed in to change notification settings - Fork 46
feat: wdio v9 compat #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vobu
wants to merge
98
commits into
main
Choose a base branch
from
v9-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: wdio v9 compat #645
+22,441
−27,801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- _navTo.cjs - allControls.cjs - executeControlMethod.cjs
Co-authored-by: Simon Coen <[email protected]>
Co-authored-by: Simon Coen <[email protected]>
Co-authored-by: Simon Coen <[email protected]>
Co-authored-by: Simon Coen <[email protected]>
Co-authored-by: Simon Coen <[email protected]>
- still BIDI problems
for wdio v9 compat
Siolto
reviewed
Oct 24, 2024
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* ci: Improve ESLint v9 config * ci: Bump GH Actions checkout and setup-node to v4 * ci: Bump GH Actions github/codeql-action/* to v3 * ci: Bump GH Actions download-artifact and upload-artifact to v4 * ci: Bump prettier version * chore: Bump types versions * chore: Linting + types * fix: Mostly any types * fix: Remove deprecated browser.switchToFrame * fix: use crypto.randomUUID * refactor: load UI5 libs in 1 task * fix: remove multiple any types * chore: linting * fix: performance (#658) * fix: performance * fix: improve error handling and result processing in executeControlMethod * fix: refactor executeObjectMethod not using callbacks * test: update DateTimePicker API test to use ISO string format * fix: update generated-methods test to handle different date formats based on protocol * fix: await browser.asControl in press test for proper asynchronous handling * fix: bidi race condition in retrieveElements * fix: update Planning Calendar test to handle BIDI-specific DOM controls * fix: optimize control retrieval for BIDI by removing unnecessary await * fix: adjust BIDI handling in exec test to avoid Promise.all for performance * chore: configuration * fix: add TODO comment for handling UI5 injection options * refactor: remove propietary waitForUI5 * refactor: run planningCalendar test also with BiDi protocol * fix: improve peformance while retrieving multiple elements (#665) [skip ci] * refactor: rename clientSide__checkForUI5Ready to clientSide_checkForUI5Ready for consistency * chore: lock file * fix: test * refactor: rm unnecessary await --------- Co-authored-by: Volker Buzek <[email protected]> * fix: use crypto.randomUUID * fix: revert * build: clean script * test: add more UI5 LTS versions * refactor: remove fs-extra * chore: pretty sure package "i" was installed by mistake * test: fix expected value * chore: update workflows to also run against v9-support * test: use a public method to test selected element * test: expect().toHaveTextContaining() doesn't exist * test: replace getInitStatus() by isInitialized() * test: fix wdio-ui5tooling.conf.js * test: remove deepmerge dependency * chore: npm shouldn't be a dependency * test: simplify test deps with peerDeps * test: replace sinon by node:test * fix: remove devtools dep * fix: use browserInstance rather than global browser * fix: no console - use wdi5 Logger * refactor: compare-versions package as a real dependency * refactor: remove more browser globals * test: add browserVersion to make tests more stable + no node:join in specs * chore: prettier * chore: remove old eslint files * fix: baseUrl is mandatory, must fail if missing * fix: load ui5 libs at once * refactor: client-side-js is also typed * fix: use control.getMetadata().getName() * docs: add statement for new bidi protocol * Update docs/migration.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * fix: multiremote race condition where injectUI5 was not done * wip: use stable ubuntu version * wip: decrease ubuntu version * chore: add multiremote to the tests again * refactor: linting * refactor: ts erasableSyntaxOnly * fix: wdio bridge * chore: use stable ubuntu version due to chrome138 pipeline issues * fix: increase timeout for ts tests in pipeline --------- Co-authored-by: Simon Coen <[email protected]> Co-authored-by: Volker Buzek <[email protected]> Co-authored-by: Marian Zeis <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Siolto <[email protected]>
Co-authored-by: I586943 <[email protected]>
* fix(deps): mv marky from dev deps * chore: update engine recos * chore(deps): update * fix(idpDomainOpt): proper assignment * fix(auth): ensure proper assignment * docs(auth): clarify idpDomain usage in multiple IdP scenarios
[skip ci] * docs: migration guide to v3 * Update docs/migration.md Co-authored-by: Simon Coen <[email protected]> * docs: update migration guide to reflect Node version support changes * fix: remove client-side-js from prettier linting command --------- Co-authored-by: Simon Coen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most kudos go to @Siolto - rockstar vibes 🤘