This repository was archived by the owner on Jan 26, 2024. It is now read-only.
Remove underscores in name variable #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FreeBSD 12 (pfSense 2.5) this script no longer works because of [this issue](https://forums.freebsd.org/threads/ezjails-admin-flavour_setup-fails-under-freebsd-13.81932/), with the root cause being the dashes in the `name` variable value. This uses underscores instead, which solves the issue and is also the standard.
ajkavanagh
previously approved these changes
Nov 13, 2021
ajkavanagh
dismissed
their stale review
Undoing as I noticed this will require doc changes as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FreeBSD 12 (pfSense 2.5) this script no longer works because of this issue, with the root cause being the dashes in the
namevariable value. This uses underscores instead, which solves the issue and is also the standard.