Skip to content

Conversation

@jawadqur
Copy link
Contributor

@jawadqur jawadqur commented Aug 29, 2023

Jira Ticket: BRH-581

New Features

  • Add cost tracking for blanket billing with karpenter
  • Add cost reporting endpoint

Breaking Changes

Bug Fixes

Improvements

image
  • This reporting is done via karpenter spinning up tagged resources, and hatchery querying cost/usage report.

Dependency updates

Deployment changes

@jawadqur jawadqur marked this pull request as ready for review November 1, 2023 16:29
@github-actions
Copy link

Please find the ci env pod logs here

@github-actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_discoverypage.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{tests/test\_workspace.py}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{2}}$$ $$\textcolor{#23d18b}{\tt{2}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@m0nhawk m0nhawk closed this Apr 2, 2025
@m0nhawk m0nhawk deleted the feat/karpenter-for-cost branch April 2, 2025 03:39
@mfshao mfshao restored the feat/karpenter-for-cost branch April 28, 2025 21:56
@mfshao
Copy link
Contributor

mfshao commented Apr 28, 2025

restoring the branch for evaluation of countinue working on this

@mfshao mfshao reopened this Apr 28, 2025
@mfshao mfshao marked this pull request as draft April 28, 2025 21:57
return nil, err
}

if payModel.Local && Config.Config.Karpenter && strings.Contains(strings.ToLower(payModel.Name), "trial") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Only "Trial Workspaces" will have cost usage reports and any "Direct Pay" workspaces will not have cost usage reports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants