Skip to content

Conversation

adombeck
Copy link
Contributor

When building Debian packages from the branch of a PR, we want to actually build what's on the branch, without changes from main.

That's especially important when preparing bugfix releases, which we build from the source packages from the CI. We don't want unexpected changes from main to end up in these releases.

When building Debian packages from the branch of a PR, we want to
actually build what's on the branch, without changes from main.

That's especially important when preparing bugfix releases, which we
build from the source packages from the CI. We don't want unexpected
changes from main to end up in these releases.
@adombeck adombeck requested a review from 3v1n0 June 18, 2025 13:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (1236577) to head (3572c6d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files          82       82           
  Lines        5794     5794           
  Branches      111      111           
=======================================
  Hits         4963     4963           
  Misses        775      775           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adombeck
Copy link
Contributor Author

@adombeck adombeck marked this pull request as ready for review June 18, 2025 13:52
@adombeck adombeck requested a review from a team as a code owner June 18, 2025 13:52
Copy link
Collaborator

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, github actions syntax is crazy 😭, but that's good.

It shouldn't still cause anything else for main, so good.

@adombeck
Copy link
Contributor Author

do you agree that we still want this PR, even though for releases we can use the artifacts built from the tag? my reasoning is that it's still unexpected that the debian packages built for a PR contain changes from main which are not in the PR branch.

@3v1n0
Copy link
Collaborator

3v1n0 commented Jun 18, 2025

Well, there are pro and cons... Like in this way we can test what would be once merged, otherwise it's also true that one can just rebase... So indeed this gives more freedom of choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants