pam/integration-tests: Add more tests ensuring authd behavior when no broker is configured #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
tests-brokerless-login
branch
from
3506670 to
8dbf2a0
Compare
adombeck
reviewed
Jun 16, 2025
Do not show the sshd messages unless we have a failure, this avoids spamming CI, but also it seems that in such context they get scrambled. At the same time they're useful during debugging, so don't change the behavior when we're in an interactive terminal
…orks It's kind implicit in the previous tests, but still let's test the non interactive behavior too
3v1n0
force-pushed
the
tests-brokerless-login
branch
from
6f07c1c to
70518a6
Compare
Otherwise mkhomedir may fail in trying to create it, and so SSH: Could not chdir to home directory /home/user-integration-cached: No such file or directory
In case the user is considered already existent: - Create the directory when parsing the DB - Ensure the directory already exists at test time Otherwise: - Ensure no user home directory exists before user has been created - Ensure the user home exists after user logged in
In case the local broker is used, it should never be auto-selected for non-local users, so do this in test
Allow to run authd without any broker, and just run the tests to ensure that we don't break this basic experience for various setups and special cases
Avoid printing unneeded private values while print the internal data, using JSON to help us doing that easily.
If safeMessageDebug is used to print multiple types, only the first one is safely parsed, while the others are not. This won't cover (and it's not even possible) to do it in case a format is used, but should allow to easily and safely print things around anyways
3v1n0
force-pushed
the
tests-brokerless-login
branch
from
70518a6 to
f8aa703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tests for the authd default state that we were not checking in any integration test before
UDENG-3646