Skip to content

Conversation

adombeck
Copy link
Contributor

dependabot keeps updating the version but it's not available in Noble, so we can't update it yet.

@adombeck adombeck force-pushed the amend-dependabot-commit branch from 69b69bd to c5685c3 Compare April 24, 2025 10:54
@adombeck
Copy link
Contributor Author

@3v1n0 this might work, but I think there's no way to test it beside merging to main and triggering another dependabot PR

@adombeck adombeck force-pushed the amend-dependabot-commit branch from c5685c3 to b05aa9a Compare April 24, 2025 10:56
@adombeck adombeck force-pushed the amend-dependabot-commit branch from b05aa9a to 8510b52 Compare April 24, 2025 10:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (8c2af1e) to head (8510b52).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   85.50%   85.43%   -0.08%     
==========================================
  Files          80       80              
  Lines        5547     5547              
  Branches      109      109              
==========================================
- Hits         4743     4739       -4     
- Misses        749      753       +4     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@3v1n0
Copy link
Collaborator

3v1n0 commented Apr 24, 2025

Good... I think it's better to experiment this...

Other way could be to try this in a local fork where main is older than the current in Ubuntu.

name: Run custom steps on Dependabot PRs

on:
pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also ad filter when changes are touching the lock file? As there's no need for go updates


- name: Amend commit and push
run: |
if git diff --quiet; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be explicit on file?

Suggested change
if git diff --quiet; then
if git diff --quiet -- "**Cargo.lock"; then

exit 0
fi

git add -A
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git add -A
git add "**Cargo.lock"

@@ -0,0 +1,35 @@
name: Run custom steps on Dependabot PRs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you may need to add permissions:

permissions:
  pull-requests: write
  contents: write

(maybe contents isn't needed?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants