-
Notifications
You must be signed in to change notification settings - Fork 29
ci: Amend dependabot commits to use Cargo.lock file version 3 #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
69b69bd
to
c5685c3
Compare
@3v1n0 this might work, but I think there's no way to test it beside merging to main and triggering another dependabot PR |
c5685c3
to
b05aa9a
Compare
b05aa9a
to
8510b52
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 85.50% 85.43% -0.08%
==========================================
Files 80 80
Lines 5547 5547
Branches 109 109
==========================================
- Hits 4743 4739 -4
- Misses 749 753 +4
Partials 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Good... I think it's better to experiment this... Other way could be to try this in a local fork where main is older than the current in Ubuntu. |
name: Run custom steps on Dependabot PRs | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also ad filter when changes are touching the lock file? As there's no need for go updates
|
||
- name: Amend commit and push | ||
run: | | ||
if git diff --quiet; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be explicit on file?
if git diff --quiet; then | |
if git diff --quiet -- "**Cargo.lock"; then |
exit 0 | ||
fi | ||
|
||
git add -A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git add -A | |
git add "**Cargo.lock" |
@@ -0,0 +1,35 @@ | |||
name: Run custom steps on Dependabot PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you may need to add permissions:
permissions:
pull-requests: write
contents: write
(maybe contents isn't needed?)
dependabot keeps updating the version but it's not available in Noble, so we can't update it yet.