Skip to content

Conversation

uberbrady
Copy link
Owner

(Copypasta'd the following from: #7 upon which this branch is based)

This is 'stacked' against the refactor_logging_squashed_rebased branch - and unifies the way we do User Merges whether they be from the CLI or from the GUI.

Now, $user->merge($bad_user) is now a new method on User. I had to get a little clever with callbacks to be able to report the same information to the CLI tool that we had before, but now there's one base of code to do all user-merging.

There was a subtle difference between how we did the CLI-merges versus the GUI merges - one would do a conventional delete() - causing a Delete action_log entry, and one would do a simple save() with deleted_at set to NOW() - which does not add an action_log. I've chosen to standardize on the "conventional delete" method, because I think the logs are clearer that way. Because of that, I needed to modify one test to reflect new, additional action_log entry.

@uberbrady uberbrady force-pushed the user_merge_for_new_logging_refactor_3 branch from 9f9b3da to 819031e Compare August 28, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant