Skip to content

Conversation

fzakaria
Copy link

@fzakaria fzakaria commented Sep 12, 2025

Description

  • Syntax in scip.bzl was broken (missing comma)
  • Renamed variable that was unused and missing
  • Updated documented to how it can use bazel_dep
  • Changed module name to have underscore since module names can't have hyphens

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement

Component(s) Affected

  • Language Server (ULSP)
  • SCIP Generation (Python utilities)
  • VS Code/Cursor Extension
  • Java Aggregator
  • Build System (Bazel)
  • Documentation
  • Tests

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (bazel test //...)
  • I have tested this manually with a real project

Manual Testing Details

Describe how you tested these changes:

  • IDE used for testing:
  • Project(s) tested against:
  • Specific features/scenarios verified:

Checklist

  • My code follows the existing code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated BUILD.bazel files if I added new source files
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots/Logs (if applicable)

Include any relevant screenshots, logs, or output that demonstrates the changes.

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Additional Notes

Any additional information that reviewers should know about this PR.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2025

CLA assistant check
All committers have signed the CLA.

@fzakaria fzakaria changed the title Fzakaria/minor tweaks Minor improvements & small bugs fixed Sep 12, 2025
Comment on lines -166 to +171
sources_folders = None
sources_folders = None,
inputs = depset(),
additional_classpath = None,
flow_prefix = "_index_sources"):
if source_folders == None:
source_folders = []
if sources_folders == None:
sources_folders = []
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were just bugs that stopped it from running.

@fzakaria
Copy link
Author

I got it to run ultimately but it didn't pass on our codebase; things like:

ERROR: file 'clients/out/clients/generated-test.srcjar_sources.txt' is generated by these conflicting actions:

Very cool project though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants