Bootstrap5 poc #84
Open
Bootstrap5 poc #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
joelpittet
reviewed
Aug 22, 2025
occupant
force-pushed
the
bootstrap5-poc
branch
from
e63e52c to
be545fa
Compare
occupant
force-pushed
the
bootstrap5-poc
branch
from
be545fa to
f5bc663
Compare
…roken so it's removed, WIP
The .open class is no longer appended to the span element, so we can trigger based on arai-expanded values of button element instead
|
@occupant let me know if/when you'd like me to poke around on this PR. |
|
@joelpittet For sure. I rebased after we committed the visual regression tests to main and committed here so I could add a test for the global utility button (which wasn't working previously). It's a little messy, but I wanted to make sure we had testing available on this branch. Hoping to clear some time soon |
…directory and allow for easier npm package management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.