Skip to content

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Mar 15, 2025

Ref #812
By Devin 🙃

of course there is no test. 🙈

seeing if it'll make one

With the fix removed, and just the test:


 FAIL  __tests__/transform/template-to-typescript.test.ts > Transform: rewriteTemplate > modifiers > in a conditional expression
Error: Snapshot `Transform: rewriteTemplate > modifiers > in a conditional expression 1` mismatched

- Expected
+ Received

- "__glintDSL__.emitContent(
  __glintDSL__.resolveOrReturn(
    (__glintDSL__.noop(__if),
    __glintRef__.args.onSelect
      ? __glintDSL__.applyModifier(
          __glintDSL__.resolve(__glintDSL__.Globals["on"])(
            __glintY__.element,
            "click",
            __glintRef__.args.onSelect,
          ),
        )
      : null),
  )(),
);
"


+ "__glintDSL__.emitContent(
  __glintDSL__.resolveOrReturn(
    (__glintDSL__.noop(__if),
    __glintRef__.args.onSelect
      ? __glintDSL__.resolve(modifier)(
          __glintDSL__.Globals["on"],
          "click",
          __glintRef__.args.onSelect,
        )
      : undefined),
  )(),
);
"

@NullVoxPopuli
Copy link
Contributor Author

So... now the question is: how close is this to being a correct test?

__glintDSL__.emitContent(
  __glintDSL__.resolveOrReturn(
    (__glintDSL__.noop(__if),
    __glintRef__.args.onSelect
      ? __glintDSL__.applyModifier(
          __glintDSL__.resolve(__glintDSL__.Globals["on"])(
            __glintY__.element,
            "click",
            __glintRef__.args.onSelect,
          ),
        )
      : null),
  )(),
);

@NullVoxPopuli NullVoxPopuli changed the title Let's see how it did Attempt to use Devin to solve #812 Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant