Fix Stacked progress width transition animation #41659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
changed the title
.progress-stack
julien-deramond
changed the title
.progress-stack
julien-deramond
changed the title
mdo
force-pushed
the
main-jd-fix-transition-progress-stack
branch
from
9f939aa to
d75bc53
Compare
|
Going to remove this from v5.3.8 for now because I don't see an obvious difference in the checkout demo right now and aim to do a weekend release if I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
The commit with the example must be removed before merging
Closes #41596
This PR adds an extra CSS rule for the animation of progress stack width.
Regular progress bars animate their width property. Stacked progress bars have their progress controlled by the parent
.progress container's width, not the individual bar's width. To fix transitions in stacked progress bars, I applied the transition to the container.There's a temporary example in the Checkout example page based on https://stackblitz.com/edit/bootstrap-5-qckpcxzb?file=src%2Findex.html to show that the fix works correctly.