loads the rails engine for rails 8 versions #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenano
changed the title
|
fixes #124 |
|
Thanks, I used this to unblock my upgrade to v8. I wonder if rather than simply appending v8, whether it'd make more sense to tweak the conditional to always require the engine for v4+, otherwise we're going to be in the same position once v9 is released, and so on. Alternatively, maybe it's time to drop support for below Rails 4, then we can require the engine across the board without a version check, being more future-proof. Rails 3 last saw a release in 2016. Rails themselves are only currently supporting v7.2+, or v7.0+ when it comes to security issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.