Fix so CODE_EXECUTOR_INGRESS_DOMAIN is only added if workflows are en… #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled When workflows.enabled is set to false, the code executor will not be deployed. The CODE_EXECUTOR_INGRESS_DOMAIN environment variable would still be added to backend deployment and prevent it from starting as the backend would try to connect to the executor on start up. With this change, the CODE_EXECUTOR_INGRESS_DOMAIN environment variable will only be added to the backend deployment if workflows are enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the problem
When
workflows.enabledis set tofalse, the code executor will not be deployed. TheCODE_EXECUTOR_INGRESS_DOMAINenvironment variable will still be added to backend deployment and prevent it from starting as the backend would try to connect to the executor during start up.You see the following error messages during boot:
You can see the problem on the current main branch by running:
helm template \ --set config.encryptionKey=key \ --set image.tag=3.148.26-stable \ --set workflows.enabled=false \ -n retool retool charts/retool | lessIn the output you can see that
CODE_EXECUTOR_INGRESS_DOMAINis set for the retool backend deployment, but there is noretool-code-executorservice.Solution
With this change, the
CODE_EXECUTOR_INGRESS_DOMAINenvironment variable will only be added to the backend deployment if workflows are enabled