feat(ecmascript): Array and TypedArray prototype toLocaleString #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
previously approved these changes
Jun 6, 2025
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
yossydev
force-pushed
the
feat/array-and-typedarray-prototype-to-locale-string
branch
from
00404f0 to
1fa0de5
Compare
aapoalas
previously approved these changes
Jun 11, 2025
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_prototype.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_prototype.rs
Outdated
Show resolved
Hide resolved
aapoalas
force-pushed
the
feat/array-and-typedarray-prototype-to-locale-string
branch
from
cf7a758 to
aaf5823
Compare
aapoalas
reviewed
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toLocaleString method should ideally conform to ECMA-402, but according to the specification, if ECMA-402 is not supported, it’s acceptable to implement it as specified in ECMA-262:
In this PR, the priority was to pass test262, so I implemented toLocaleString for Array and TypedArray.
doc
ref