fix: Added GPT-4o compatibility for screenshot actions with text parameter #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jagjeevan Kashid <[email protected]>
JagjeevanAK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jagjeevan Kashid [email protected]
What
Solved issue #344
Approach
GPT-4o models now send an additional parameter with screenshot actions for descriptive context, but CUA's computer handlers only accepted basic parameters. The agent execution logic passes all action parameters via **kwargs, causing a TypeError.
so to mitigate this I have added an
optional parameterto all screenshot method implementations:Validation: Verified against OpenAI docs. While the docs show basic screenshot actions without text parameters, GPT-4o models are implementing enhanced behavior by including descriptive reasoning text.