Skip to content

Create DNS entries for additional 'domainNames' of Fargate services #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create DNS entries for additional 'domainNames' of Fargate services #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions packages/truemark-cdk-lib/aws-ecs/lib/standard-application-fargate-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ export interface StandardApplicationFargateServiceProps extends StandardFargateS
readonly domainZone?: IHostedZone;
}

/**
* Domain name information associated with a service.
*/
export interface StandardApplicationFargateServiceDomain {
readonly domainName: DomainName;
readonly route53Record: ARecord;
}

/**
* Creates an ECS Fargate service and maps it to an Application Load Balancer (ALB).
*/
Expand All @@ -162,6 +170,7 @@ export class StandardApplicationFargateService extends StandardFargateService {
readonly listener: IApplicationListener;
readonly domainName?: DomainName;
readonly route53Record?: ARecord;
readonly domainRecords: Record<string, StandardApplicationFargateServiceDomain>;

constructor(scope: Construct, id: string, props: StandardApplicationFargateServiceProps) {
super(scope, id, props);
Expand Down Expand Up @@ -245,10 +254,27 @@ export class StandardApplicationFargateService extends StandardFargateService {
priority: props.targetGroupPriority ?? 1
});

this.domainRecords = {};

if (props.domainName !== undefined && props.domainZone !== undefined) {
this.domainName = DomainName.fromFqdn(props.domainName, props.domainZone);
this.route53Record = this.domainName.createARecord(this,
RecordTarget.fromAlias(new LoadBalancerTarget(loadBalancer)));

this.domainRecords[props.domainName] = {
domainName: this.domainName,
route53Record: this.route53Record
}
}

if (props.domainNames !== undefined && props.domainZone !== undefined) {
for (const name of props.domainNames) {
const dn = DomainName.fromFqdn(name, props.domainZone);
this.domainRecords[name] = {
domainName: dn,
route53Record: dn.createARecord(this, RecordTarget.fromAlias(new LoadBalancerTarget(loadBalancer)))
}
}
}

this.loadBalancer = loadBalancer;
Expand Down
2 changes: 1 addition & 1 deletion packages/truemark-cdk-lib/aws-vpc/lib/network-parameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ export class NetworkParameters extends Construct implements IAutomationComponent
parameterName: this.publicSubnetsParameterPath,
stringListValue: props.publicSubnetIds
});
this.publicSubnetIds = props.privateSubnetIds;
this.publicSubnetIds = props.publicSubnetIds;
}
if (props.privateSubnetIds) {
this.privateSubnetsParameter = new StringListParameter(this, "PrivateSubnets", {
Expand Down