Rename the keyword gravity_constant
to gravity
for the ShallowWaterEquations3D
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
gravity_constant
keyword in the equations constructor togravity
and fixes the docstrings/comments to describe this quantity as the gravitational acceleration instead of the gravitational constant. This will make it consistent with the actual field equations.gravity and avoid any confusion between gravitational acceleration and the gravitational constant. See trixi-framework/TrixiShallowWater.jl#82, trixi-framework/TrixiShallowWater.jl#84, trixi-framework/Trixi.jl#2357