-
Notifications
You must be signed in to change notification settings - Fork 119
Use only required OrdinaryDiffEq
subpackage
#2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use only required OrdinaryDiffEq
subpackage
#2392
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
I discussed this with Hendrik in #2266 (comment). Importing both packages allows to easily switch between integrators. But I would still be fine with this. |
examples/dgmulti_1d/elixir_euler_shu_osher_gauss_shock_capturing.jl
Outdated
Show resolved
Hide resolved
Ah thanks! Yeah this PR is heavily personally biased, as I always get annoyed when I create a new branch from main and have to include and precompile two packages 😶🌫️ |
…ng.jl Co-authored-by: Joshua Lampert <[email protected]>
Yeah, I guess it makes sense to only leave the required subpackage, especially since you already did the (probably annoying (or did you (semi)automate this? 🤔)) work 😅 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
==========================================
+ Coverage 94.92% 96.95% +2.03%
==========================================
Files 504 504
Lines 41717 41721 +4
==========================================
+ Hits 39599 40448 +849
+ Misses 2118 1273 -845
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Could you please add this to the agenda for the next meeting to see what the others think about it? |
using
only the required package should be sufficient and relieves the user from the need to add 2 packages if only 1 is needed.