Added deleteServiceNextDescendentOnly function #20
Conversation
skootrivir
changed the title
phalestrivir
force-pushed
the
trivir
branch
3 times, most recently
from
94375fc to
ebf6df8
Compare
skootrivir
force-pushed
the
serviceopschange
branch
from
2c88581 to
c061150
Compare
src/ops/ServiceOps.ts
Outdated
| @@ -46,6 +47,10 @@ export type Service = { | |||
| serviceId: string, | |||
| globalConfig?: boolean | |||
| ): Promise<AmServiceSkeleton>; | |||
| deleteServiceNextDescendentOnly( | |||
There was a problem hiding this comment.
I would rename this to be deleteServiceNextDecendants, since it will be for deleting all next descendants of the service. Same for all other references to the function in this file
src/ops/ServiceOps.ts
Outdated
| throw new FrodoError( | ||
| `Error deleting ${ | ||
| globalConfig ? 'global' : 'realm' | ||
| } full service config ${serviceId}`, |
There was a problem hiding this comment.
This error needs to be updated to indicate that there was a failure deleting the next descendants.
src/ops/ServiceOps.ts
Outdated
| @@ -590,6 +604,46 @@ export async function deleteFullService({ | |||
| } | |||
| } | |||
|
|
|||
| export async function deleteServiceNextDescentdentOnly({ | |||
There was a problem hiding this comment.
Since this function is just copy/paste from the deleteFullService function, you should refactor deleteFullService to use this function for deleting the next descendants to reduce code redundancy.
src/ops/ServiceOps.ts
Outdated
| @@ -46,6 +47,10 @@ export type Service = { | |||
| serviceId: string, | |||
| globalConfig?: boolean | |||
| ): Promise<AmServiceSkeleton>; | |||
| deleteServiceNextDescendentOnly( | |||
There was a problem hiding this comment.
Missing documentation above this function
src/ops/ServiceOps.ts
Outdated
| @@ -124,7 +129,16 @@ export default (state: State): Service => { | |||
| ): Promise<AmServiceSkeleton> { | |||
| return deleteFullService({ serviceId, globalConfig, state }); | |||
| }, | |||
|
|
|||
| async deleteServiceNextDescendentOnly( | |||
There was a problem hiding this comment.
Missing documentation above this function
src/ops/ServiceOps.ts
Outdated
| @@ -590,6 +604,46 @@ export async function deleteFullService({ | |||
| } | |||
| } | |||
|
|
|||
| export async function deleteServiceNextDescentdentOnly({ | |||
There was a problem hiding this comment.
Missing documentation above this function
No description provided.