-
Notifications
You must be signed in to change notification settings - Fork 8
fix: remove hostname from nextUri using regex #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
@georgewfisher @mosabua Can you please take a look? |
I just submitted the CLA. |
thanks for making this, lgtm. I was having problems of running it in certain docker environments due to the same issue. |
@koszti Can you please approve the GHA workflows and tag the maintainers for CR? |
Closing and re-opening to see if CLA can be re-evaluated. |
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Finally got my CLA processed today |
Description
Use regex instead of hardcoded url to remove hostname from nextUri. This allows us to use a different proxy target in vite.config.ts
Additional context and related issues