Skip to content

Conversation

jiezhang
Copy link

@jiezhang jiezhang commented Jul 29, 2025

Description

Use regex instead of hardcoded url to remove hostname from nextUri. This allows us to use a different proxy target in vite.config.ts

Additional context and related issues

Copy link

cla-bot bot commented Jul 29, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@jiezhang
Copy link
Author

@georgewfisher @mosabua Can you please take a look?

@jiezhang
Copy link
Author

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

I just submitted the CLA.

@koszti
Copy link
Member

koszti commented Jul 31, 2025

thanks for making this, lgtm. I was having problems of running it in certain docker environments due to the same issue.

@jiezhang
Copy link
Author

jiezhang commented Aug 1, 2025

@koszti Can you please approve the GHA workflows and tag the maintainers for CR?

@jiezhang
Copy link
Author

jiezhang commented Aug 1, 2025

Closing and re-opening to see if CLA can be re-evaluated.

@jiezhang jiezhang closed this Aug 1, 2025
@jiezhang jiezhang reopened this Aug 1, 2025
Copy link

cla-bot bot commented Aug 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@jiezhang
Copy link
Author

jiezhang commented Aug 9, 2025

Finally got my CLA processed today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants