Provide an option to use orjson instead of json #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
May 29, 2025
|
The purpose to use orjson is mainly to fasten the process of fetching query results from Trino servers. This PR is still a draft. I have to fix the CI failures. I'm going to write the description before making this PR ready for review. |
|
thanks, it would also be helpful to see some measurements with and without this change to get an idea of the impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
orjson is a fast JSON library in Python.
https://github.com/ijl/orjson?tab=readme-ov-file#performance
In my usage,
json.loads()is one of the bottlenecks in performance when fetching a large result from a query.Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: