[OCI Helm repo compatability]: Add support for optional skip of passing versions of k8s and APIs from command line #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GolubevV
changed the title
|
@travisghansen any feedback on this PR ?? |
|
Can you send an example of how/when the oci bits break? I use oci registries and haven’t ran into this issue for some reason. |
|
I guess this is no longer relevant in context of #71 |
|
Yes I believe you are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, Helmfile is passing all supplied arguments and env varialbes down
to
Helmtool.However, in the case of working with OCI repositories for Helm charts, helmfile performs explicit pull from OCI before render and does not support the extra args that are inherited like
--kube-versionor--api-verssions.As a result, it fails with the error like
Error: unknown flag: --kube-versionThis PR allows to skip passing the K8s and API versions if corresponding ENV variable
HELMFILE_PASS_VERSIONSis set to false. By default, if not explicitly specified, it will be set totrueto be backward compatible with previous behaviour.@travisghansen - please tell. if you think we should consider to include this parameter into
discoveryoutput thus making it globally visible.