Skip to content

Du 40/shared plans #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 31, 2025
Merged

Du 40/shared plans #3478

merged 10 commits into from
Jul 31, 2025

Conversation

nrios14
Copy link
Contributor

@nrios14 nrios14 commented Jun 18, 2025

No description provided.

stan-travis
stan-travis approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@stan-travis stan-travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stan-travis stan-travis self-requested a review June 25, 2025 13:42
stan-travis
stan-travis previously approved these changes Jun 25, 2025
View reviewed changes
michal-at-travisci
michal-at-travisci requested changes Jun 25, 2025
View reviewed changes
user/images/user-activity-tab-tcie.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is admin-v2 screen, it shouldn't go to the public docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it touches activity check on users, this tool and validation is mostly important for TCIE and such screen and isnturctions should go to the TCIe parts of documentation, Please remove from thios PR.

user/images/suspend-users-screen.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is admin-v2 screen, it shouldn't go to the public docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it touches suspend functionality, whcih is meant for TCIE deployments - that should be exzcluded to TCIE docs, there it makes sense (admin-v2 is available for TCIE admins)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove from this PR.

@nrios14
Copy link
Contributor Author

nrios14 commented Jun 27, 2025 •
edited
Loading

The page was updated with suggestions.
Please review it and let me know if anything else should be modified.

Also, where in the sidebar should I add this new page? Please advise so I can add it.

michal-at-travisci
michal-at-travisci approved these changes Jul 31, 2025
View reviewed changes
@nrios14 nrios14 merged commit 9e63737 into master Jul 31, 2025
1 check passed
@nrios14 nrios14 deleted the DU-40/Shared_Plans branch July 31, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michal-at-travisci michal-at-travisci michal-at-travisci approved these changes

@stan-travis stan-travis stan-travis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrios14 @michal-at-travisci @stan-travis